<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
Hi guys!<br>
<br>
I agree with Francisco.<br>
<br>
With the first option you are going to have problems the second
time that you use the extension. In my opinion the third option is
the best one, but I can understand that the second one is faster to
fix.<br>
<br>
Regards,<br>
Jorge<br>
<br>
Regards,<br>
Jorge<br>
<br>
El 28/12/2010 19:09, Nacho Uve escribió:
<blockquote
cite="mid:AANLkTi=WFg+oNbfa4yq8wYC_a-cO06=J93xQ4xD3bgt5@mail.gmail.com"
type="cite">Yes!! You are right!! Thank you, Puga!!<br>
<br>
Maybe the best choice is the second one ("pass a different
actionCommand string").<br>
<br>
I'll wait for core-developers opinion before fix my patch. <br>
<br>
Regards,<br>
Nacho Varela<br>
<br>
<br>
<div class="gmail_quote">2010/12/28 Francisco Puga <span><<a
moz-do-not-send="true" href="mailto:fpuga@cartolab.es">fpuga@cartolab.es</a>></span><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Hi,<br>
<br>
I just review the patch and i found a trouble with it. I wrote
my<br>
comment in the bugtracker but also i paste it here:<br>
<br>
There is a problem with the provided patch. If you use the
filter over<br>
a layer (from the FilterExtension itself or from other
extension), the<br>
attribute datasource of the class is set, so the second time
that you<br>
try to use it from the FilterExtension it will use the
previous<br>
datasource and not the new.<br>
<br>
I think that there are three different approach to handle
this:<br>
* Set datasource to null after calling the method doExecute()<br>
* Pass a different actionCommand string to the execute method
if it's<br>
used from a external extension<br>
* Maybe, refactor to extract the logic from the class
extension<br>
itself, and instantiated the new class each time is needed.<br>
<br>
El día 28 de diciembre de 2010 13:19, Nacho Uve <<a
moz-do-not-send="true" href="mailto:nachouve@gmail.com">nachouve@gmail.com</a>>
escribió:<br>
<div class="im">> Although not fully related to the
previous mail, I would like report on the<br>
> new ticket[1] that I sent to Tracker about
FiltroExtension.<br>
><br>
> That's a trivial patch to add a new method
setDataSource() on<br>
> FiltroExtension. That change do NOT modify the current
behaviour of the<br>
> tool, but it allows to use it on other contexts (p.e
with NavTable[2]).<br>
><br>
> Please, take a look to the patch and tell me if it is
possible to apply<br>
> it... and of course, any idea about "filter decimal
bug"?<br>
><br>
> Thank you!<br>
><br>
> Regards,<br>
> Nacho Varela<br>
><br>
> [1]:<br>
> <a moz-do-not-send="true"
href="https://forge.osor.eu/tracker/index.php?func=detail&aid=14912&group_id=89&atid=790">https://forge.osor.eu/tracker/index.php?func=detail&aid=14912&group_id=89&atid=790</a><br>
> [2]:<br>
> <a moz-do-not-send="true"
href="https://forge.osor.eu/tracker/index.php?func=detail&aid=14908&group_id=122&atid=462">https://forge.osor.eu/tracker/index.php?func=detail&aid=14908&group_id=122&atid=462</a><br>
</div>
_______________________________________________<br>
gvSIG_desarrolladores mailing list<br>
<a moz-do-not-send="true"
href="mailto:gvSIG_desarrolladores@listserv.gva.es">gvSIG_desarrolladores@listserv.gva.es</a><br>
<a moz-do-not-send="true"
href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores</a><br>
</blockquote>
</div>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
gvSIG_desarrolladores mailing list
<a class="moz-txt-link-abbreviated" href="mailto:gvSIG_desarrolladores@listserv.gva.es">gvSIG_desarrolladores@listserv.gva.es</a>
<a class="moz-txt-link-freetext" href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores</a>
</pre>
</blockquote>
<br>
</body>
</html>