I'm very happy!! The ticket was assigned to a developer[1] (fdiaz).<br>Thank you very much!!<br><br>[1]: <a href="http://forge.osor.eu/tracker/?func=detail&atid=790&aid=14912&group_id=89">http://forge.osor.eu/tracker/?func=detail&atid=790&aid=14912&group_id=89</a><br>
<br><br><br><div class="gmail_quote">2010/12/29 Nacho Uve <span dir="ltr"><<a href="mailto:nachouve@gmail.com">nachouve@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hummmm... Jorge, there are a lot of things to do on the refactoring... there are also
many variables and comments in spanish that should be translated.<br><br>Now I do not feel qualified to implement third option... maybe next year! ;-)<br><br>I do a small patch<span lang="en">[1]</span> uploaded on the ticket[2] just to for a quick solution to our current problem and <span lang="en"> <span title="Haz clic para obtener traducciones alternativas">to</span> <span title="Haz clic para obtener traducciones alternativas">incorporate</span> <span title="Haz clic para obtener traducciones alternativas">the new functionality that</span> <span title="Haz clic para obtener traducciones alternativas">I'm creating</span> <span title="Haz clic para obtener traducciones alternativas">for</span> <span title="Haz clic para obtener traducciones alternativas">NavTable</span><span title="Haz clic para obtener traducciones alternativas">.</span><br>
</span><br>I also fix a trivial bug... Vector layer name was not shown on the title of the FiltroDialog. <br><br>Please check it, and tell me if it is possible to apply the patch.<br>Thank you very much!<br><br>[1]: <a href="https://forge.osor.eu/tracker/download.php/89/790/14912/6928/filter_setDataSource_method_v2.patch" target="_blank">https://forge.osor.eu/tracker/download.php/89/790/14912/6928/filter_setDataSource_method_v2.patch</a><br>
[2]: <a href="https://forge.osor.eu/tracker/index.php?func=detail&aid=14912&group_id=89&atid=790" target="_blank">https://forge.osor.eu/tracker/index.php?func=detail&aid=14912&group_id=89&atid=790</a><br>
<br><br><br>
<br><div class="gmail_quote">El 29 de diciembre de 2010 08:16, Jorge Piera Llodrá <span dir="ltr"><<a href="mailto:jpiera@prodevelop.es" target="_blank">jpiera@prodevelop.es</a>></span> escribió:<div><div></div><div class="h5">
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div text="#000000" bgcolor="#ffffff">
Hi guys!<br>
<br>
I agree with Francisco.<br>
<br>
With the first option you are going to have problems the second
time that you use the extension. In my opinion the third option is
the best one, but I can understand that the second one is faster to
fix.<br>
<br>
Regards,<br>
Jorge<br>
<br>
Regards,<br>
Jorge<br>
<br>
El 28/12/2010 19:09, Nacho Uve escribió:
<div><div></div><div><blockquote type="cite">Yes!! You are right!! Thank you, Puga!!<br>
<br>
Maybe the best choice is the second one ("pass a different
actionCommand string").<br>
<br>
I'll wait for core-developers opinion before fix my patch. <br>
<br>
Regards,<br>
Nacho Varela<br>
<br>
<br>
<div class="gmail_quote">2010/12/28 Francisco Puga <span><<a href="mailto:fpuga@cartolab.es" target="_blank">fpuga@cartolab.es</a>></span><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi,<br>
<br>
I just review the patch and i found a trouble with it. I wrote
my<br>
comment in the bugtracker but also i paste it here:<br>
<br>
There is a problem with the provided patch. If you use the
filter over<br>
a layer (from the FilterExtension itself or from other
extension), the<br>
attribute datasource of the class is set, so the second time
that you<br>
try to use it from the FilterExtension it will use the
previous<br>
datasource and not the new.<br>
<br>
I think that there are three different approach to handle
this:<br>
* Set datasource to null after calling the method doExecute()<br>
* Pass a different actionCommand string to the execute method
if it's<br>
used from a external extension<br>
* Maybe, refactor to extract the logic from the class
extension<br>
itself, and instantiated the new class each time is needed.<br>
<br>
El día 28 de diciembre de 2010 13:19, Nacho Uve <<a href="mailto:nachouve@gmail.com" target="_blank">nachouve@gmail.com</a>>
escribió:<br>
<div>> Although not fully related to the
previous mail, I would like report on the<br>
> new ticket[1] that I sent to Tracker about
FiltroExtension.<br>
><br>
> That's a trivial patch to add a new method
setDataSource() on<br>
> FiltroExtension. That change do NOT modify the current
behaviour of the<br>
> tool, but it allows to use it on other contexts (p.e
with NavTable[2]).<br>
><br>
> Please, take a look to the patch and tell me if it is
possible to apply<br>
> it... and of course, any idea about "filter decimal
bug"?<br>
><br>
> Thank you!<br>
><br>
> Regards,<br>
> Nacho Varela<br>
><br>
> [1]:<br>
> <a href="https://forge.osor.eu/tracker/index.php?func=detail&aid=14912&group_id=89&atid=790" target="_blank">https://forge.osor.eu/tracker/index.php?func=detail&aid=14912&group_id=89&atid=790</a><br>
> [2]:<br>
> <a href="https://forge.osor.eu/tracker/index.php?func=detail&aid=14908&group_id=122&atid=462" target="_blank">https://forge.osor.eu/tracker/index.php?func=detail&aid=14908&group_id=122&atid=462</a><br>
</div>
_______________________________________________<br>
gvSIG_desarrolladores mailing list<br>
<a href="mailto:gvSIG_desarrolladores@listserv.gva.es" target="_blank">gvSIG_desarrolladores@listserv.gva.es</a><br>
<a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores</a><br>
</blockquote>
</div>
<br>
<pre><fieldset></fieldset>
_______________________________________________
gvSIG_desarrolladores mailing list
<a href="mailto:gvSIG_desarrolladores@listserv.gva.es" target="_blank">gvSIG_desarrolladores@listserv.gva.es</a>
<a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
gvSIG_desarrolladores mailing list<br>
<a href="mailto:gvSIG_desarrolladores@listserv.gva.es" target="_blank">gvSIG_desarrolladores@listserv.gva.es</a><br>
<a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_desarrolladores</a><br>
<br></blockquote></div></div></div><br><br clear="all"><br>-- <br><div><div>Juan Ignacio Varela García</div><div>Consultor en tecnologías SIG</div><div>Analista-Desarrollador FLOSS</div><div><br></div><div>Oficina Técnica Sistemas Información Xeográfica</div>
<div>Consellería de Medio Ambiente, Territorio e Infraestructuras</div><div>Dirección Xeral Sostibilidade e Paisaxe (Xunta de Galicia)</div><div><br></div><div><a href="http://www.cmati.xunta.es" target="_blank">http://www.cmati.xunta.es</a></div>
<div>Tfno: 981.54.17.02</div></div><br>
</blockquote></div><br><br clear="all"><br>-- <br><div><div>Juan Ignacio Varela García</div><div>Consultor en tecnologías SIG</div><div>Analista-Desarrollador FLOSS</div><div><br></div><div>Oficina Técnica Sistemas Información Xeográfica</div>
<div>Consellería de Medio Ambiente, Territorio e Infraestructuras</div><div>Dirección Xeral Sostibilidade e Paisaxe (Xunta de Galicia)</div><div><br></div><div><a href="http://www.cmati.xunta.es" target="_blank">http://www.cmati.xunta.es</a></div>
<div>Tfno: 981.54.17.02</div></div><br>