I did the patch via Subversive plugin of Eclipse, as I did the first time. <br>If there are problems with the last I sent I could remake it tomorrow.<br>I'm not that good at reading diffs.. :(<br><br><div class="gmail_quote">
2010/3/8 Benjamin Ducke <span dir="ltr"><<a href="mailto:benjamin.ducke@oxfordarch.co.uk">benjamin.ducke@oxfordarch.co.uk</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Oh, yes, I applied the patch manually because I wanted to<br>
understand what it does. Didn't even realize that Eclipse<br>
does patches. Can it book flights and boil eggs too, now?<br>
<br>
Does the "patch" command line tool not work for you?<br>
<div class="im"><br>
Cheers,<br>
<br>
Ben<br>
<br>
----- Original Message -----<br>
From: "Francisco José Peñarrubia" <<a href="mailto:fpenarru@gmail.com">fpenarru@gmail.com</a>><br>
To: "Users and Developers mailing list" <<a href="mailto:gvsig_internacional@listserv.gva.es">gvsig_internacional@listserv.gva.es</a>><br>
</div><div><div></div><div class="h5">Sent: Monday, March 8, 2010 6:54:32 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna<br>
Subject: Re: [Gvsig_english] gvSIG 1.9 patch for managing measured 3D Polylines of Shapefiles<br>
<br>
You are right, the diff file contains this lines..... But when I try to<br>
patch libFMap, Eclipse does nothing...<br>
<br>
I will investigate further....<br>
<br>
Fran.<br>
<br>
Benjamin Ducke escribió:<br>
> Hmmm, the patch I saved from Flavio's last email has<br>
> this, following line 515:<br>
><br>
> - case (SHP.POLYLINE2D):<br>
> - case (SHP.POLYLINE3D):<br>
> + case SHP.POLYLINE2D:<br>
><br>
> auxType = auxType | FShape.LINE;<br>
> break;<br>
> -<br>
> - case (SHP.POLYLINEM):<br>
> + case SHP.POLYLINEM:<br>
><br>
> auxType = auxType | FShape.LINE | FShape.M;<br>
> break;<br>
> + case SHP.POLYLINE3D:<br>
><br>
> + auxType = auxType | FShape.LINE | FShape.Z;<br>
><br>
> + break;<br>
><br>
><br>
> ... is that not it?<br>
><br>
> Flavio, I think we need your opinion!<br>
><br>
> Ben<br>
><br>
> ----- Original Message -----<br>
> From: "Francisco José Peñarrubia" <<a href="mailto:fpenarru@gmail.com">fpenarru@gmail.com</a>><br>
> To: "Users and Developers mailing list" <<a href="mailto:gvsig_internacional@listserv.gva.es">gvsig_internacional@listserv.gva.es</a>><br>
> Sent: Monday, March 8, 2010 6:15:25 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna<br>
> Subject: Re: [Gvsig_english] gvSIG 1.9 patch for managing measured 3D Polylines of Shapefiles<br>
><br>
> Hi Ben.<br>
><br>
> Sorry, I don't understand. Why do you feel irritated??.<br>
><br>
> Flavio sent some months ago a patch. I put the patch in gvSIG official<br>
> SVN, and now, comparing this new patch and the code<br>
><br>
> case SHP.POLYLINE2D:<br>
> auxType = auxType | FShape.LINE;<br>
> break;<br>
> case SHP.POLYLINEM:<br>
> auxType = auxType | FShape.LINE | FShape.M;<br>
> break;<br>
> case SHP.POLYLINE3D:<br>
> auxType = auxType | FShape.LINE | FShape.Z;<br>
> break;<br>
><br>
><br>
> I can't find this code inside the last patch. It seems (for me, at last)<br>
> that the patch maybe and old one, and that's why I'm asking his opinion...<br>
><br>
> Cheers.<br>
><br>
> Fran.<br>
><br>
> Benjamin Ducke escribió:<br>
><br>
>> Hi Fran,<br>
>><br>
>> this irritates me a little. I just merged this patch<br>
>> into the OADE codebase and everything was in there,<br>
>> just as Flavio said it should.<br>
>><br>
>> Cheers,<br>
>><br>
>> Ben<br>
>><br>
>> ----- Original Message -----<br>
>> From: "Francisco José Peñarrubia" <<a href="mailto:fpenarru@gmail.com">fpenarru@gmail.com</a>><br>
>> To: "Users and Developers mailing list" <<a href="mailto:gvsig_internacional@listserv.gva.es">gvsig_internacional@listserv.gva.es</a>><br>
>> Sent: Monday, March 8, 2010 5:30:21 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna<br>
>> Subject: Re: [Gvsig_english] gvSIG 1.9 patch for managing measured 3D Polylines of Shapefiles<br>
>><br>
>> Hi Flavio.<br>
>><br>
>> First of all, thanks for the patch.<br>
>><br>
>> And now, my question: It seems the patch file doesn't have this<br>
>> changes... Is it possible that you sent and old patch? (The old patch is<br>
>> already in SVN).<br>
>><br>
>> Best regards.<br>
>><br>
>> Fran.<br>
>><br>
>> Flavio Pompermaier escribió:<br>
>><br>
>><br>
>>> Hi Francisco,<br>
>>> I discovered these days that the patch for managing 4d shapefiles I<br>
>>> sent to you some weeks ago is uncomplete.<br>
>>> 4D shapefiles are read correctly with that patch, but if I start<br>
>>> editing them and then I save them, the shapeWriter do not work as<br>
>>> expected.<br>
>>> The malfunctioning is caused by the fact that when the shapeWriter<br>
>>> tries to get the layer type<br>
>>> the IndexedShpDriver collapse 2d and 4d shapefiles to the same type of<br>
>>> layer:<br>
>>><br>
>>> case (SHP.POLYLINEM):<br>
>>> auxType = auxType | FShape.LINE | FShape.M;<br>
>>> break;<br>
>>> case (SHP.POLYLINE2D):<br>
>>> case (SHP.POLYLINE3D):<br>
>>> auxType = auxType | FShape.LINE;<br>
>>> break;<br>
>>><br>
>>> while it must be:<br>
>>><br>
>>> case SHP.POLYLINE2D:<br>
>>> auxType = auxType | FShape.LINE;<br>
>>> break;<br>
>>> case SHP.POLYLINEM:<br>
>>> auxType = auxType | FShape.LINE | FShape.M;<br>
>>> break;<br>
>>> case SHP.POLYLINE3D:<br>
>>> auxType = auxType | FShape.LINE | FShape.Z;<br>
>>> break;<br>
>>><br>
>>> The new version of the patch of libFMap is attached to the mail.<br>
>>> Best regards,<br>
>>> Flavio<br>
>>><br>
>>><br>
>>> 2010/2/1 Flavio Pompermaier <<a href="mailto:fla83tn@libero.it">fla83tn@libero.it</a> <mailto:<a href="mailto:fla83tn@libero.it">fla83tn@libero.it</a>>><br>
>>><br>
>>> Hi Francisco,<br>
>>> I was thinking nobody read my email..<br>
>>> However, I tested the solution against the attached shapefile,<br>
>>> which has x,y,z and m dimension (although z is always 0...).<br>
>>> I didn't test legends and labelling because by now I use it like a<br>
>>> normal 3D shapefile.<br>
>>> But if you do it it should be certainly a good idea!<br>
>>> Moreover I didn't test non-indexed shapefiles but I don't even<br>
>>> know if they exist..and also if they do<br>
>>> it seems to me that the code to manage them is always passing<br>
>>> through the classes I modified.<br>
>>><br>
>>> Thanks for keeping me up to date,<br>
>>> Flavio<br>
>>><br>
>>><br>
>>> 2010/1/29 Francisco José Peñarrubia <<a href="mailto:fpenarru@gmail.com">fpenarru@gmail.com</a><br>
>>> <mailto:<a href="mailto:fpenarru@gmail.com">fpenarru@gmail.com</a>>><br>
>>><br>
>>> Hi Flavio.<br>
>>><br>
>>> Sorry about this late response... :-(.<br>
>>><br>
>>> About the patch, we are going to evaluate it. Please, can you<br>
>>> send us<br>
>>> some shapefiles to test, and one or two use cases?.<br>
>>> We are going to test also some legends, and labelling (just in<br>
>>> case you<br>
>>> haven't tested it yet).<br>
>>><br>
>>> Thanks a lot for this collaboration, and keep going, please.<br>
>>><br>
>>> Fran Peñarrubia.<br>
>>> gvSIG Team<br>
>>><br>
>>> Flavio Pompermaier escribió:<br>
>>> > Hi to all,<br>
>>> > In the project I' working on I had the need of managing M<br>
>>> dimension of<br>
>>> > PolylineZ contained in shapefiles<br>
>>> > and I had to modify the libFMap and read also M coordinate for<br>
>>> > Shape.POLYLINE3D.<br>
>>> > The patch is attached to this mail.<br>
>>> > I'd like to know whether this patch could be added of<br>
>>> interest for a<br>
>>> > cumulative further patch of gvSIG 1.9.<br>
>>> ><br>
>>> ><br>
>>> -------------------------------------------------------------------------------------------------------------------------------------------------------<br>
>>> > Brief summary:<br>
>>> ><br>
>>> -------------------------------------------------------------------------------------------------------------------------------------------------------<br>
>>> > - Class ShapeZMFactory proxies the creation of Z-geometries<br>
>>> with four<br>
>>> > coordinates. By now only polylines<br>
>>> > are managed but, if somedays there will be the need of<br>
>>> managing also<br>
>>> > Zpoints, Zmultipoints and Zpolygons<br>
>>> > with four dimension, you can always implement method for their<br>
>>> > creation in the aforementioned class.<br>
>>> ><br>
>>> > - Class FPolyline3DM extends FPolyline3D in order to manage m<br>
>>> > dimension of PolylineZ shapes<br>
>>> ><br>
>>> > - Class IndexedShpDriver instead manage the reading of m<br>
>>> coordinate<br>
>>> > from shapefiles..<br>
>>> ><br>
>>> --------------------------------------------------------------------------------------------------------------------------------------------------------<br>
>>> ><br>
>>> > If anyone knows if I've forgotten to touch other classes in<br>
>>> order to<br>
>>> > make my patch complete is pleased to let<br>
>>> > me know about it.<br>
>>> ><br>
>>> > Best regards,<br>
>>> > Flavio Pompermaier<br>
>>> ><br>
>>> ><br>
>>> ------------------------------------------------------------------------<br>
>>> ><br>
>>> > _______________________________________________<br>
>>> > Gvsig_internacional mailing list<br>
>>> > <a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
>>> <mailto:<a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a>><br>
>>> ><br>
>>> <a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
>>> ><br>
>>><br>
>>> _______________________________________________<br>
>>> Gvsig_internacional mailing list<br>
>>> <a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
>>> <mailto:<a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a>><br>
>>> <a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
>>><br>
>>><br>
>>><br>
>>> ------------------------------------------------------------------------<br>
>>><br>
>>> _______________________________________________<br>
>>> Gvsig_internacional mailing list<br>
>>> <a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
>>> <a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
>>><br>
>>><br>
>> _______________________________________________<br>
>> Gvsig_internacional mailing list<br>
>> <a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
>> <a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
>><br>
>><br>
>><br>
>> ------<br>
>> Files attached to this email may be in ISO 26300 format (OASIS Open Document Format). If you have difficulty opening them, please visit <a href="http://iso26300.info" target="_blank">http://iso26300.info</a> for more information.<br>
>><br>
>> _______________________________________________<br>
>> Gvsig_internacional mailing list<br>
>> <a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
>> <a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
>><br>
>><br>
><br>
> _______________________________________________<br>
> Gvsig_internacional mailing list<br>
> <a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
> <a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
><br>
><br>
> ------<br>
> Files attached to this email may be in ISO 26300 format (OASIS Open Document Format). If you have difficulty opening them, please visit <a href="http://iso26300.info" target="_blank">http://iso26300.info</a> for more information.<br>
><br>
> _______________________________________________<br>
> Gvsig_internacional mailing list<br>
> <a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
> <a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
><br>
<br>
_______________________________________________<br>
Gvsig_internacional mailing list<br>
<a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
<a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
<br>
<br>
------<br>
Files attached to this email may be in ISO 26300 format (OASIS Open Document Format). If you have difficulty opening them, please visit <a href="http://iso26300.info" target="_blank">http://iso26300.info</a> for more information.<br>
<br>
_______________________________________________<br>
Gvsig_internacional mailing list<br>
<a href="mailto:Gvsig_internacional@listserv.gva.es">Gvsig_internacional@listserv.gva.es</a><br>
<a href="http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional" target="_blank">http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional</a><br>
</div></div></blockquote></div><br>