[Gvsig_english] Several patches for PostGIS driver

[Benjamin Ducke]

Hi Andres,

many thanks for these patches! They fix a lot of annoying problems.
I have reviewed them as much as I could, but I don't have a working
PostGIS setup at the moment, so could not test them myself.

I have some questions/comments:

1. Regarding the handling of "gid" and "the_geom" fields.
I have reviewed the PostGIS docs and did not find a statement
that says these fields must be called "gid" or "the_geom".
So I guess it's fine to use something like "gid1" for the
primary key. However, googling around a bit I got the impression
that some software always assumes that "gid" and "the_geom"
exist with these names. Clearly, it's not gvSIG's fault that
some other software assumes something that is not guaranteed.
But to guard users from potential trouble when interchanging
data with other applications: should we display a warning message
if "gid" or "the_geom" are changed to another name?

2. Regarding case-sensitivity in gvSIG.
This is something that has needed fixing for a long time and
I am glad you addressed this problem. However, did you test
how your patches interact with the gvSIG GUI? My impression
was that some dialogs are not case-sensitive for field names.
E.g., I was not able to rename a PostGIS field from "fielda"
to "FieldA", because the field manager dialog thought the two
were the same names. To clarify: I don't think there is anything
wrong with how your patches work. But I am afraid there may
be more parts of gvSIG's GUI that need patching.

Again, thanks for your work. It really improves a key component
of gvSIG.

Best,

Ben


----- Original Message -----
> Hi all,
> 
> last weeks, CartoLab has been working on PostGIS driver for gvsig
> 1.10.
> 
> We have posted all patches in the OSOR bugtracker. As it could be
> interesting for some of you, we'are summing up here all the fixes
> provided (see below).
> 
> We have tested all of the patches provided and also how they work
> together. Our initial tests seems to show that PostGIS driver is more
> stable and user-friendly with them. Nevertheless, we're open to
> discuss if it's worth applying them and if they introduce any
> regression we
> haven't realized.
> 
> We hope that they are useful to you.
> 
> PostGIS patches:
> 
> [#14537] Unable to export to postgis when a field called gid already
> exists:
> https://forge.osor.eu/tracker/?func=detail&aid=14537&group_id=89&atid=732
> 
> [#14556] Geoproceso recortar capas desde postgis consola error:
> https://forge.osor.eu/tracker/index.php?func=detail&aid=14556&group_id=89&atid=732
> 
> [#14555] Postgis driver: while create new layer, generate gid name
> taking into account other fields names
> https://forge.osor.eu/tracker/index.php?func=detail&aid=14555&group_id=89&atid=732
> 
> [#14554] Don't allow user to leave blank the name of a layer to export
> https://forge.osor.eu/tracker/index.php?func=detail&aid=14554&group_id=89&atid=732
> 
> [#14547] Several errorDialog are launched for the same exception
> https://forge.osor.eu/tracker/index.php?func=detail&aid=14547&group_id=89&atid=732
> 
> [#14546] PostGIS Driver should be case sensitive
> https://forge.osor.eu/tracker/index.php?func=detail&aid=14546
> 
> [#14308] Lost connection after every SQL fail
> https://forge.osor.eu/tracker/index.php?func=detail&aid=14308
> 
> [#14545] Postgis driver: show only tables the user has privileges over
> https://forge.osor.eu/tracker/index.php?func=detail&aid=14545&group_id=89&atid=790
> 
> [#14400] No reconoce el tipo de datos smallint
> https://forge.osor.eu/tracker/index.php?func=detail&aid=14400
> 
> best,
> amaneiro
> 
> PS: sorry for the cross-posting, but we though this message could be
> interesting for developers and for some of people in
> gvsig-international too.
> _______________________________________________ Gvsig_internacional
> mailing list
> Gvsig_internacional at listserv.gva.es
> http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional


------
Files attached to this email may be in ISO 26300 format (OASIS Open Document Format). If you have difficulty opening them, please visit http://iso26300.info for more information.