[Gvsig_english] gvSIG 1.9 patch for managing measured 3D Polylines of Shapefiles
Francisco José Peñarrubia
fpenarru at gmail.com
Mon Mar 8 18:54:32 CET 2010
You are right, the diff file contains this lines..... But when I try to
patch libFMap, Eclipse does nothing...
I will investigate further....
Fran.
Benjamin Ducke escribió:
> Hmmm, the patch I saved from Flavio's last email has
> this, following line 515:
>
> - case (SHP.POLYLINE2D):
> - case (SHP.POLYLINE3D):
> + case SHP.POLYLINE2D:
>
> auxType = auxType | FShape.LINE;
> break;
> -
> - case (SHP.POLYLINEM):
> + case SHP.POLYLINEM:
>
> auxType = auxType | FShape.LINE | FShape.M;
> break;
> + case SHP.POLYLINE3D:
>
> + auxType = auxType | FShape.LINE | FShape.Z;
>
> + break;
>
>
> ... is that not it?
>
> Flavio, I think we need your opinion!
>
> Ben
>
> ----- Original Message -----
> From: "Francisco José Peñarrubia" <fpenarru at gmail.com>
> To: "Users and Developers mailing list" <gvsig_internacional at listserv.gva.es>
> Sent: Monday, March 8, 2010 6:15:25 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
> Subject: Re: [Gvsig_english] gvSIG 1.9 patch for managing measured 3D Polylines of Shapefiles
>
> Hi Ben.
>
> Sorry, I don't understand. Why do you feel irritated??.
>
> Flavio sent some months ago a patch. I put the patch in gvSIG official
> SVN, and now, comparing this new patch and the code
>
> case SHP.POLYLINE2D:
> auxType = auxType | FShape.LINE;
> break;
> case SHP.POLYLINEM:
> auxType = auxType | FShape.LINE | FShape.M;
> break;
> case SHP.POLYLINE3D:
> auxType = auxType | FShape.LINE | FShape.Z;
> break;
>
>
> I can't find this code inside the last patch. It seems (for me, at last)
> that the patch maybe and old one, and that's why I'm asking his opinion...
>
> Cheers.
>
> Fran.
>
> Benjamin Ducke escribió:
>
>> Hi Fran,
>>
>> this irritates me a little. I just merged this patch
>> into the OADE codebase and everything was in there,
>> just as Flavio said it should.
>>
>> Cheers,
>>
>> Ben
>>
>> ----- Original Message -----
>> From: "Francisco José Peñarrubia" <fpenarru at gmail.com>
>> To: "Users and Developers mailing list" <gvsig_internacional at listserv.gva.es>
>> Sent: Monday, March 8, 2010 5:30:21 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
>> Subject: Re: [Gvsig_english] gvSIG 1.9 patch for managing measured 3D Polylines of Shapefiles
>>
>> Hi Flavio.
>>
>> First of all, thanks for the patch.
>>
>> And now, my question: It seems the patch file doesn't have this
>> changes... Is it possible that you sent and old patch? (The old patch is
>> already in SVN).
>>
>> Best regards.
>>
>> Fran.
>>
>> Flavio Pompermaier escribió:
>>
>>
>>> Hi Francisco,
>>> I discovered these days that the patch for managing 4d shapefiles I
>>> sent to you some weeks ago is uncomplete.
>>> 4D shapefiles are read correctly with that patch, but if I start
>>> editing them and then I save them, the shapeWriter do not work as
>>> expected.
>>> The malfunctioning is caused by the fact that when the shapeWriter
>>> tries to get the layer type
>>> the IndexedShpDriver collapse 2d and 4d shapefiles to the same type of
>>> layer:
>>>
>>> case (SHP.POLYLINEM):
>>> auxType = auxType | FShape.LINE | FShape.M;
>>> break;
>>> case (SHP.POLYLINE2D):
>>> case (SHP.POLYLINE3D):
>>> auxType = auxType | FShape.LINE;
>>> break;
>>>
>>> while it must be:
>>>
>>> case SHP.POLYLINE2D:
>>> auxType = auxType | FShape.LINE;
>>> break;
>>> case SHP.POLYLINEM:
>>> auxType = auxType | FShape.LINE | FShape.M;
>>> break;
>>> case SHP.POLYLINE3D:
>>> auxType = auxType | FShape.LINE | FShape.Z;
>>> break;
>>>
>>> The new version of the patch of libFMap is attached to the mail.
>>> Best regards,
>>> Flavio
>>>
>>>
>>> 2010/2/1 Flavio Pompermaier <fla83tn at libero.it <mailto:fla83tn at libero.it>>
>>>
>>> Hi Francisco,
>>> I was thinking nobody read my email..
>>> However, I tested the solution against the attached shapefile,
>>> which has x,y,z and m dimension (although z is always 0...).
>>> I didn't test legends and labelling because by now I use it like a
>>> normal 3D shapefile.
>>> But if you do it it should be certainly a good idea!
>>> Moreover I didn't test non-indexed shapefiles but I don't even
>>> know if they exist..and also if they do
>>> it seems to me that the code to manage them is always passing
>>> through the classes I modified.
>>>
>>> Thanks for keeping me up to date,
>>> Flavio
>>>
>>>
>>> 2010/1/29 Francisco José Peñarrubia <fpenarru at gmail.com
>>> <mailto:fpenarru at gmail.com>>
>>>
>>> Hi Flavio.
>>>
>>> Sorry about this late response... :-(.
>>>
>>> About the patch, we are going to evaluate it. Please, can you
>>> send us
>>> some shapefiles to test, and one or two use cases?.
>>> We are going to test also some legends, and labelling (just in
>>> case you
>>> haven't tested it yet).
>>>
>>> Thanks a lot for this collaboration, and keep going, please.
>>>
>>> Fran Peñarrubia.
>>> gvSIG Team
>>>
>>> Flavio Pompermaier escribió:
>>> > Hi to all,
>>> > In the project I' working on I had the need of managing M
>>> dimension of
>>> > PolylineZ contained in shapefiles
>>> > and I had to modify the libFMap and read also M coordinate for
>>> > Shape.POLYLINE3D.
>>> > The patch is attached to this mail.
>>> > I'd like to know whether this patch could be added of
>>> interest for a
>>> > cumulative further patch of gvSIG 1.9.
>>> >
>>> >
>>> -------------------------------------------------------------------------------------------------------------------------------------------------------
>>> > Brief summary:
>>> >
>>> -------------------------------------------------------------------------------------------------------------------------------------------------------
>>> > - Class ShapeZMFactory proxies the creation of Z-geometries
>>> with four
>>> > coordinates. By now only polylines
>>> > are managed but, if somedays there will be the need of
>>> managing also
>>> > Zpoints, Zmultipoints and Zpolygons
>>> > with four dimension, you can always implement method for their
>>> > creation in the aforementioned class.
>>> >
>>> > - Class FPolyline3DM extends FPolyline3D in order to manage m
>>> > dimension of PolylineZ shapes
>>> >
>>> > - Class IndexedShpDriver instead manage the reading of m
>>> coordinate
>>> > from shapefiles..
>>> >
>>> --------------------------------------------------------------------------------------------------------------------------------------------------------
>>> >
>>> > If anyone knows if I've forgotten to touch other classes in
>>> order to
>>> > make my patch complete is pleased to let
>>> > me know about it.
>>> >
>>> > Best regards,
>>> > Flavio Pompermaier
>>> >
>>> >
>>> ------------------------------------------------------------------------
>>> >
>>> > _______________________________________________
>>> > Gvsig_internacional mailing list
>>> > Gvsig_internacional at listserv.gva.es
>>> <mailto:Gvsig_internacional at listserv.gva.es>
>>> >
>>> http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional
>>> >
>>>
>>> _______________________________________________
>>> Gvsig_internacional mailing list
>>> Gvsig_internacional at listserv.gva.es
>>> <mailto:Gvsig_internacional at listserv.gva.es>
>>> http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Gvsig_internacional mailing list
>>> Gvsig_internacional at listserv.gva.es
>>> http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional
>>>
>>>
>> _______________________________________________
>> Gvsig_internacional mailing list
>> Gvsig_internacional at listserv.gva.es
>> http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional
>>
>>
>>
>> ------
>> Files attached to this email may be in ISO 26300 format (OASIS Open Document Format). If you have difficulty opening them, please visit http://iso26300.info for more information.
>>
>> _______________________________________________
>> Gvsig_internacional mailing list
>> Gvsig_internacional at listserv.gva.es
>> http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional
>>
>>
>
> _______________________________________________
> Gvsig_internacional mailing list
> Gvsig_internacional at listserv.gva.es
> http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional
>
>
> ------
> Files attached to this email may be in ISO 26300 format (OASIS Open Document Format). If you have difficulty opening them, please visit http://iso26300.info for more information.
>
> _______________________________________________
> Gvsig_internacional mailing list
> Gvsig_internacional at listserv.gva.es
> http://listserv.gva.es/cgi-bin/mailman/listinfo/gvsig_internacional
>
More information about the Gvsig_internacional
mailing list